This repository has been archived by the owner on Oct 10, 2024. It is now read-only.
Pass all SessionDelegate
callbacks through to TurboNavigationDelegate
#73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the conversation from #72, this approach passes all unused
SessionDelegate
callbacks throughTurboNavigationDelegate
without modification.This gives developers an option to override whatever part of
SessionDelegate
they want. They can implement their functionality in their existingTurboNavigationDelegate
extension.It also provides a default
WKUIDelegate
implementation, handling alerts and confirmation dialogs. If a developer wants more customization they are encouraged to copy-paste theextension TurboNavigator: WKUIDelegate
extension and overwrite and/or add functionality of their own. MakingcurrentNavigationController
public enables this to be possible.